Skip to content

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 23, 2022

Display for ParamTy and ParamConst is implemented in terms of print.
Using print avoids creating a new FmtPrinter just to display the
parameter name.

r? @Mark-Simulacrum

Display for `ParamTy` and `ParamConst` is implemented in terms of print.
Using print avoids creating a new `FmtPrinter` just to display the
parameter name.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 23, 2022
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Feb 23, 2022

📌 Commit eaf4c91 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2022
@bors
Copy link
Collaborator

bors commented Feb 24, 2022

⌛ Testing commit eaf4c91 with merge 964119a9fa2ec97c2e316ad7ce59307d0556ee01...

@bors
Copy link
Collaborator

bors commented Feb 24, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2022
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@tmiasko
Copy link
Contributor Author

tmiasko commented Feb 24, 2022

@bors retry error: failed to download from https://crates.io/api/v1/crates/quote/1.0.7/download

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2022
@bors
Copy link
Collaborator

bors commented Feb 25, 2022

⌛ Testing commit eaf4c91 with merge 6cbc6c3...

@bors
Copy link
Collaborator

bors commented Feb 25, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6cbc6c3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 25, 2022
@bors bors merged commit 6cbc6c3 into rust-lang:master Feb 25, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 25, 2022
@tmiasko tmiasko deleted the write-print branch February 25, 2022 18:34
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6cbc6c3): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants